-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified Links and Updated ReadMe #106
Conversation
Looks good; the new minified links aren't minified there is also https://github.com/LeeWannacott/table-sort-js/blob/master/public/docs/html5.html#LL71C1-L71C1 . Which is this page: https://leewannacott.github.io/table-sort-js/docs/html5.html |
Hey @Cioraz , After thinking about this more I don't think we need to do @1 we could just do https://cdn.jsdelivr.net/npm/table-sort-js/table-sort.js and https://cdn.jsdelivr.net/npm/table-sort-js/table-sort.min.js for the minified version; I think this is less confusing. @Cioraz Sorry for the inconvenience; would you be able to change the links to these instead? |
Sure I'll change them |
@Cioraz This latest commit looks good, the second commit is changing a bunch of stuff that doesn't need to be changed. You could run |
Hey, im running into a few errors doing what you stated above. Could I create another pull request with only these changes ? |
Sure, no worries. |
Done in PR #107 |
Changes to the Links and Readme. #100